feat(VpcV2): adding imports for SubnetV2 and VpcV2(WIP) #31765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-cdk-automation
previously requested changes
Oct 15, 2024
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
shikha372
force-pushed
the
vpcv2_imports
branch
from
c9e2d27
to
e1b038c
Compare
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
shikha372
changed the title
shikha372
force-pushed
the
vpcv2_imports
branch
from
f8a1645
to
00eebb9
Compare
aws-cdk-automation
added
the
pr/needs-maintainer-review
shikha372
force-pushed
the
vpcv2_imports
branch
from
35857d9
to
13d1458
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Tracking #30762.
Reason for this change
Allow users to define imports for a VPC or subnet defined outside current stack definition.
Description of changes
Added new methods under VpcV2 and Subnet
VpcV2.fromVpcV2Attributes()andSubnetV2.fromSubnetV2Attributes()Added new L2 for VPCCidrBlock to allow import of secondary addresses.
VPCCidrBlockAdded new integration test and unit test file to check import related functionality.
Updated Readme.
Fixed an earlier issue with subnet range check, fixed to include IPAM defined IPv4 address as well
Description of how you validated changes
Deployed and tested for below scenarios in account:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license